chore(ci): Remove IMAGE_OS setting#637
Merged
nealrichardson merged 1 commit intomainfrom Feb 19, 2025
Merged
Conversation
nealrichardson
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
Author
|
The integration testing job that was modified in this PR passes: https://github.com/posit-dev/rsconnect-python/actions/runs/13401139629/job/37437096302?pr=637 IDK what's up with the Seems to be failing since January 29: https://github.com/posit-dev/rsconnect-python/actions/runs/13027921854 |
edavidaja
approved these changes
Feb 19, 2025
nealrichardson
force-pushed
the
image-os
branch
from
6719d18 to
8696714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #633. Turns out we already are using public images for testing, and from what I infer from #588, this was just being added to prevent a script from looking for it and erroring if it wasn't set. Due to changes in the Connect source, this variable isn't being used anymore, so we can drop the reference.